|
reelseo
|
 |
|
| « on: May 19, 2009, 09:14:23 PM » |
|
Since the last update, which is great as I see that it minifies plugins that are not set up for such, I noticed that it is ignoring the CSS files that I ask it to ignore. As a result, my themes (old & new) are not styled correctly. Please advise. Im not sure why it screws it up when minified, but I cant even have it ignore it for troubleshooting. Once the plugin is activated, everything is minified... Thanks for your help in advance. |
|
|
|
|
Logged
|
|
|
|
|
|
reelseo
|
|
|
| « Reply #1 on: May 19, 2009, 09:16:06 PM » |
|
Additionally, it appears that it is not minifying css properly as it was previously - I actually am seeing none of my styles reflected..
|
|
|
|
|
Logged
|
|
|
|
|
|
reelseo
|
|
|
| « Reply #2 on: May 19, 2009, 09:29:29 PM » |
|
|
|
|
|
|
Logged
|
|
|
|
|
|
Thaya
|
|
|
| « Reply #3 on: May 25, 2009, 02:56:07 PM » |
|
I just fixed a CSS exclusion bug in version 0.2.1. Can you give that a try to see if it helps any?
|
|
|
|
|
Logged
|
|
|
|
|
|
reelseo
|
|
|
| « Reply #4 on: May 28, 2009, 01:59:59 AM » |
|
Thanks Thaya, that does help.... However, I think that I wouldnt have to modify the plugin to exlude the css if it loaded in the same order that it does without the plugin. It appears to be loading my main style last.. Is it because of where I have it in the header?
|
|
|
|
|
Logged
|
|
|
|
|
|
Thaya
|
|
|
| « Reply #5 on: May 28, 2009, 09:19:39 AM » |
|
The plugin now parses the CSS in the order that it appears when you do a view source on your page.
By the way, if you post on the premium forums, I am able to respond quicker since I'm subscribed to all threads there.
|
|
|
|
|
Logged
|
|
|
|
|
|
reelseo
|
|
|
| « Reply #6 on: June 10, 2009, 04:37:11 PM » |
|
So, Thaya, Im having a bitch of a time with wp-minify. Im trying to troubleshoot, the same what that I was with firebug (thankfully, you confirmed that this is how it should be troubleshooted), and I have had to remove every single JS (exclude from minify), and I still am getting 400 bad request. Ive even cleared the minify cache. Can you help?
|
|
|
|
|
Logged
|
|
|
|
|
|
reelseo
|
|
|
| « Reply #7 on: June 10, 2009, 05:06:22 PM » |
|
Seems to me that the only thing that works is when I remove everything and then remove all but the first 2 minify cache strings... Arghh... Ill pay ya if you can help me figure this out... IF you need login to wordpress, happy to give it to you or anything else.. Thanks.
|
|
|
|
|
Logged
|
|
|
|
|
|
reelseo
|
|
|
| « Reply #8 on: June 10, 2009, 05:33:40 PM » |
|
Update = looks like I found one of the problems - it was minifying outside js, in particular, the stupid tweetmeme that I have on my site. That being said, I could still really use some help in getting this to work better as Im not sure what can be minified and what can not? I also have some js in the footer which Im not sure if I should add to minify or if it has to be in the head...
|
|
|
|
|
Logged
|
|
|
|
|
|
Thaya
|
|
|
| « Reply #9 on: June 12, 2009, 01:16:48 AM » |
|
WP Minify should not be minifying anything that is embeded JS. It should only be minifying js files that are being referenced. Here is some Minify documentation about what causes some JS files to break Minify: http://code.google.com/p/minify/wiki/CommonProblems.Right now, WP Minify will grab all JS files in your site and stick it into the head section. This is because if WP Minify sticks it in the footer, many embeded JS that depends on external JavaScript files will not work. (i.e. the external JS files get loaded after your embeded JS code and it will obviously not work). |
|
|
|
|
Logged
|
|
|
|
|
|
reelseo
|
|
|
| « Reply #10 on: June 13, 2009, 11:20:05 PM » |
|
THaya, not totally sure i understand what you mean by embedded js but Ill tell you this, it seems to minify, or try to, every js on my site. So, for example, in my header and sidebar template files, Im using outside js to call, for example, add2any bookmarking tools and vodpod videos widget. I have to exclude these. Additionally, it is minifying things within i-frames. So, for example, my search page is a page built within wordpress, where I am using Google custom search to do the search on my site. This breaks when I turn on wp-minify. Intense debate comments break, as well which is odd because this is a plugin, and I see that it works on your site....etc.. Does this sound right? The problem is that within all my files, posts, pages, etc..., there are plenty of JS calls, depending on the page/post/etc... - for example, posts with videos from outsite, that seem to break as soon as I activate the new wp-minify. It isnt just minifying plugins that produce js. Does that make sense? Is that how this should be working or do I have a problem?
|
|
|
|
|
Logged
|
|
|
|
|
|
Thaya
|
|
|
| « Reply #11 on: June 14, 2009, 11:49:33 PM » |
|
That makes sense. It is supposed to grab all javascripts that are referenced on your page. Intense Debate and other external JS works on my site because I exclude them from the exclusion list. Do you think it might help if I make an option to *not* attempt to minify anything that is an external JS call?
|
|
|
|
|
Logged
|
|
|
|
|
|
reelseo
|
|
|
| « Reply #12 on: June 15, 2009, 12:22:56 AM » |
|
Absolutely.... I suppose Ill go through the plugin and exclude js one at a time until it works. Im also finding that the manual clear cache button doesnt seem to work. I had to set the expiration to a few seconds to see things working. Im also not sure I understand what the debugging mode does, I still get 404 errors when it isnt being minified, but still combined...
|
|
|
|
|
Logged
|
|
|
|
|
|
reelseo
|
|
|
| « Reply #13 on: June 15, 2009, 12:26:05 AM » |
|
Would also be good - not minifying external js for the following reason, lets say I embed a video that is called via JS but dont add it to the exclusion list, then it doesnt work and If I didnt know this, I would spend all sorts of time trying to figure out why the video wouldnt display.... ;-) I could always add it to the "include" minify if I wanted to add it later.
PS, would also be nice to use the plugin with option to turn on or off css/js. IE, right now, I cant use the plugin until I figure this issue out with the external JS files. However, it would still be nice to be able to minify the css by turning off minify JS. Lastly, can you, once minified, move the JS to the footer?
|
|
|
|
|
Logged
|
|
|
|
|
|
reelseo
|
|
|
| « Reply #14 on: June 15, 2009, 12:29:46 AM » |
|
Sorry, one more thought, dont know the ramifications.. Here is the example - I use OIOpublisher for my self-service ads (even though self-service is not active yet). Because the self-service URL for the pages is cryptic, I added htaccess to redirect /wp-content/plugins/oiopublisher/ etc.... to /adserver/ which works great and everthing appears to be at reelseo.com/adserver. However, when I do this, and try and minify, for example reelseo.com/adserver/style.css, it returns an error in firebug. I assume that it cant pick-up the 301 redirect
|
|
|
|
|
Logged
|
|
|
|
|
|
Plugin Support
