next »

[keremerkan]

When building the css and js URL, if there are no extra options for wp-minify, the URL has an extra & in it, and when the newly added "m" parameter is added to this url, the URL is broken like this:

http://....../f=js_to_minify.js&&m=123456

To avoid this, in check_and_split_url function, the following part:

else {
  return array($base_url . '?f=' . urlencode(implode(',', $files)) . $debug_url);
      }

should be changed like this:

else {
  if ( !empty($wpm_options['extra_minify_options']) )
    return array($base_url . '?f=' . implode(',', $files) . $debug_url . '&' . $wpm_options['extra_minify_options']);
  else
    return array($base_url . '?f=' . implode(',', $files)) . $debug_url;
      }

[keremerkan]

Also for w3C standard compatibility, the query string should be encoded. So it is better to change the code mentioned above to this one:

else {
  if ( !empty($wpm_options['extra_minify_options']) )
    return array($base_url . '?f=' . urlencode(implode(',', $files) . $debug_url . '&' . $wpm_options['extra_minify_options']));
  else
    return array($base_url . '?f=' . urlencode(implode(',', $files)) . $debug_url);
      }

Also the "&m=" in css and js url building code should be changed to "&m="

After these two changes, the page can pass W3C XHTML compatibility test.

Cheers!

[keremerkan]

Also, to remove duplicate css or js entries and avoid HTTP 400 errors, the code should be changed to this (this effectively solves the problem in wp-login.php I mentioned earlier):

else {
  if ( !empty($wpm_options['extra_minify_options']) )
    return array($base_url . '?f=' . urlencode(implode(',', array_unique($files)) . $debug_url . '&' . $wpm_options['extra_minify_options']));
  else
    return array($base_url . '?f=' . urlencode(implode(',', array_unique($files))) . $debug_url);
}

This is the final one. 

[Thaya]

Looks good. I'll try to work it into the next version this weekend or so.

[Thaya]

This was released in 0.8.0.