next »

[Thaya]

Question from Kerem:

First, thanks for this wonderful plugin. It's one of my essential plugins and I cannot do without it.

In 0.7.1, I have found a little problem for my site. When enabled, WP-Minify breaks wp-login.php style badly not harming functionality (actually it really has no style because of WP-Minify). In 0.6.x this problem did not exist.

So, I changed the initialization code to the following:

if (!is_admin() && stripos($_SERVER['REQUEST_URI'], 'wp-login.php') === false ) {
        // No need to minify admin stuff
        add_action('init', array($this, 'pre_content'), 99999);
        add_action('wp_footer', array($this, 'post_content'));
        // advertise hook
        add_action('wp_footer', array($this, 'advertise'));
      }

And the problem has gone. Maybe you may have a better idea about checking to see if we are on wp-login.php.

[Thaya]

Do you by any change use WP125? Looks like they are including wp125.css twice on the wp-login.php page causing WP Minify to break. I will try to add some sort of deduping algorithm into WP Minify in a point release.

[keremerkan]

Nope, never heard of it actually until you mentioned

[Thaya]

Can you go through the troubleshooting guide to see which one is the problematic script?

http://omninoggin.com/wordpress-posts/how-to-troubleshoot-wp-minify/

[keremerkan]

Hmmm, OK, I found the culprit:

/wp-content/plugins/fancybox-for-wordpress/css/fancybox.css

is included twice and when I disable WP-Minify, I can see that it is really included twice in wp-login.php.

Can I suggest something at this point? As it is up to you to create the minify URL, it shouldn't be hard to add all variables into an array, remove twice loaded ones and again create the URL. (Well author of Fancbox plugin should obviously fix this problem but wouldn't removing duplicates ease your troubleshooting burden?)

[OreilleMalade]

I've got a HUGE problem with new version of Minify (0.7.1).

I'm French & quite a noob ;-) so I hope I'm clear enough...

Just have a look to my home :
http://www.oreille-malade.com

With previous versions of Minify my site worked perfectly.

I tried to desactivate Minify but my site doesn't work better. Actually some pages load absolutely correctly, some others don't (especially my homepage).

I'm completely lost...

Thanks for your help ! 


EDIT : I downgraded to Minify 7.0 then 6.5.... But I definitely can't get my website to work correctly.
I just don't know what to do now to fix that mess 

EDIT : A few minutes later it looks to work normal with Minify 6.5
I'm not changing anything for the moment - it's bedtime in France
Let me know if you have any idea about the issue I'm dealing with.

Best Regards

[Thaya]

Hmmm, OK, I found the culprit:

/wp-content/plugins/fancybox-for-wordpress/css/fancybox.css

is included twice and when I disable WP-Minify, I can see that it is really included twice in wp-login.php.

Can I suggest something at this point? As it is up to you to create the minify URL, it shouldn't be hard to add all variables into an array, remove twice loaded ones and again create the URL. (Well author of Fancbox plugin should obviously fix this problem but wouldn't removing duplicates ease your troubleshooting burden?)

Yeah I'm planning to do some sort of de-duping algorithm in the next release. Stay tune!

[Thaya]

De-duping is released with 0.8.0.